Browse Source

chore: augment promisifyMultiArg deprecation (#17066)

Shelley Vohr 6 years ago
parent
commit
d9c7735a04

+ 4 - 1
lib/browser/api/content-tracing.js

@@ -5,6 +5,9 @@ const contentTracing = process.atomBinding('content_tracing')
 contentTracing.getCategories = deprecate.promisify(contentTracing.getCategories)
 contentTracing.startRecording = deprecate.promisify(contentTracing.startRecording)
 contentTracing.stopRecording = deprecate.promisify(contentTracing.stopRecording)
-contentTracing.getTraceBufferUsage = deprecate.promisifyMultiArg(contentTracing.getTraceBufferUsage)
+contentTracing.getTraceBufferUsage = deprecate.promisifyMultiArg(
+  contentTracing.getTraceBufferUsage,
+  (value) => [value.paths, value.bookmarks]
+)
 
 module.exports = contentTracing

+ 1 - 1
lib/common/api/deprecate.ts

@@ -102,7 +102,7 @@ const deprecate: ElectronInternal.DeprecationUtil = {
     } as T
   },
 
-  promisifyMultiArg: <T extends (...args: any[]) => any>(fn: T): T => {
+  promisifyMultiArg: <T extends (...args: any[]) => any>(fn: T, convertPromiseValue: (v: any) => any): T => {
     const fnName = fn.name || 'function'
     const oldName = `${fnName} with callbacks`
     const newName = `${fnName} with Promises`

+ 1 - 1
typings/internal-electron.d.ts

@@ -66,7 +66,7 @@ declare namespace ElectronInternal {
     renameProperty<T, K extends (keyof T & string)>(object: T, oldName: string, newName: K): T;
 
     promisify<T extends (...args: any[]) => any>(fn: T): T;
-    promisifyMultiArg<T extends (...args: any[]) => any>(fn: T): T;
+    promisifyMultiArg<T extends (...args: any[]) => any>(fn: T, convertPromiseValue: (v: any) => any): T;
   }
 
   // Internal IPC has _replyInternal and NO reply method