Browse Source

feat: Add electron version to framework (#14296)

* Add electron version to framework

* Update Info.plist
Jacob Groundwater 6 years ago
parent
commit
d9a7fee79a
2 changed files with 3 additions and 1 deletions
  1. 1 1
      BUILD.gn
  2. 2 0
      atom/common/resources/mac/Info.plist

+ 1 - 1
BUILD.gn

@@ -526,7 +526,7 @@ if (is_mac) {
       deps += [ ":electron_crashpad_helper" ]
     }
     info_plist = "atom/common/resources/mac/Info.plist"
-    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework" ]
+    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework", "ELECTRON_VERSION=$electron_version" ]
 
     include_dirs = [ "." ]
     sources = filenames_gypi.framework_sources

+ 2 - 0
atom/common/resources/mac/Info.plist

@@ -12,5 +12,7 @@
 	<string>FMWK</string>
 	<key>NSSupportsAutomaticGraphicsSwitching</key>
 	<true/>
+	<key>CFBundleVersion</key>
+	<string>${ELECTRON_VERSION}</string>
 </dict>
 </plist>