Browse Source

build: add missing `ELECTRON_ARTIFACTS_BLOB_STORAGE` env var (#42402)

build: add missing ELECTRON_ARTIFACTS_BLOB_STORAGE env var
Shelley Vohr 10 months ago
parent
commit
d97dcf388a
2 changed files with 8 additions and 1 deletions
  1. 1 0
      .github/workflows/macos-build.yml
  2. 7 1
      script/lib/azput.js

+ 1 - 0
.github/workflows/macos-build.yml

@@ -34,6 +34,7 @@ env:
   AZURE_STORAGE_ACCOUNT: ${{ secrets.AZURE_STORAGE_ACCOUNT }}
   AZURE_STORAGE_KEY: ${{ secrets.AZURE_STORAGE_KEY }}
   AZURE_STORAGE_CONTAINER_NAME: ${{ secrets.AZURE_STORAGE_CONTAINER_NAME }}
+  ELECTRON_ARTIFACTS_BLOB_STORAGE: ${{ secrets.ELECTRON_ARTIFACTS_BLOB_STORAGE }}
   ELECTRON_RBE_JWT: ${{ secrets.ELECTRON_RBE_JWT }}
   ELECTRON_GITHUB_TOKEN: ${{ secrets.ELECTRON_GITHUB_TOKEN }}
   GN_CONFIG: ${{ inputs.GN_CONFIG }}

+ 7 - 1
script/lib/azput.js

@@ -5,7 +5,13 @@ const path = require('node:path');
 // TODO(vertedinde): This variable is a test variable in GHA, sending test
 // artifacts to a test account. Change to the real electron artifacts
 // storage account when ready.
-const blobServiceClient = BlobServiceClient.fromConnectionString(process.env.ELECTRON_ARTIFACTS_BLOB_STORAGE);
+const { ELECTRON_ARTIFACTS_BLOB_STORAGE } = process.env;
+if (!ELECTRON_ARTIFACTS_BLOB_STORAGE) {
+  console.error('Missing required ELECTRON_ARTIFACTS_BLOB_STORAGE environment variable.');
+  process.exit(1);
+}
+
+const blobServiceClient = BlobServiceClient.fromConnectionString(ELECTRON_ARTIFACTS_BLOB_STORAGE);
 
 const args = require('minimist')(process.argv.slice(2));