Browse Source

fix: don't try to dump swiftshader symbols on mac (#19261)

* fix: don't try to dump swiftshader symbols on mac

* fix: don't try to generate swiftshader symbols on arm
trop[bot] 5 years ago
parent
commit
d545757191
1 changed files with 6 additions and 22 deletions
  1. 6 22
      BUILD.gn

+ 6 - 22
BUILD.gn

@@ -819,24 +819,6 @@ if (is_mac) {
       ]
     }
 
-    extract_symbols("swiftshader_egl_syms") {
-      binary = "$root_out_dir/libswiftshader_libEGL.dylib"
-      symbol_dir = "$root_out_dir/breakpad_symbols"
-      dsym_file = "$root_out_dir/libswiftshader_libEGL.dylib.dSYM/Contents/Resources/DWARF/libswiftshader_libEGL.dylib"
-      deps = [
-        "//third_party/swiftshader/src/OpenGL/libEGL:swiftshader_libEGL",
-      ]
-    }
-
-    extract_symbols("swiftshader_gles_syms") {
-      binary = "$root_out_dir/libswiftshader_libGLESv2.dylib"
-      symbol_dir = "$root_out_dir/breakpad_symbols"
-      dsym_file = "$root_out_dir/libswiftshader_libGLESv2.dylib.dSYM/Contents/Resources/DWARF/libswiftshader_libGLESv2.dylib"
-      deps = [
-        "//third_party/swiftshader/src/OpenGL/libGLESv2:swiftshader_libGLESv2",
-      ]
-    }
-
     extract_symbols("crashpad_handler_syms") {
       binary = "$root_out_dir/crashpad_handler"
       symbol_dir = "$root_out_dir/breakpad_symbols"
@@ -852,8 +834,6 @@ if (is_mac) {
         ":electron_app_syms",
         ":electron_framework_syms",
         ":electron_helper_syms",
-        ":swiftshader_egl_syms",
-        ":swiftshader_gles_syms",
       ]
     }
   } else {
@@ -995,9 +975,13 @@ if (is_mac) {
     group("electron_symbols") {
       deps = [
         ":electron_app_symbols",
-        ":swiftshader_egl_symbols",
-        ":swiftshader_gles_symbols",
       ]
+      if (target_cpu == "x86" || target_cpu == "x64") {
+        deps += [
+          ":swiftshader_egl_symbols",
+          ":swiftshader_gles_symbols",
+        ]
+      }
     }
   }
 }