Browse Source

fix: diagnostic reporting capabilities in Node.js (#23126)

Shelley Vohr 5 years ago
parent
commit
d0f19d8369
2 changed files with 18 additions and 8 deletions
  1. 18 2
      patches/node/build_add_gn_build_files.patch
  2. 0 6
      script/node-disabled-tests.json

+ 18 - 2
patches/node/build_add_gn_build_files.patch

@@ -7,10 +7,10 @@ This adds GN build files for Node, so we don't have to build with GYP.
 
 diff --git a/BUILD.gn b/BUILD.gn
 new file mode 100644
-index 0000000000000000000000000000000000000000..22d119036d12c396af935fe85ae18751e6d80562
+index 0000000000000000000000000000000000000000..2d8952a1d23af0ab4b3e5de0e56ec1e30c77dd71
 --- /dev/null
 +++ b/BUILD.gn
-@@ -0,0 +1,360 @@
+@@ -0,0 +1,376 @@
 +import("//electron/build/asar.gni")
 +import("//v8/gni/v8.gni")
 +
@@ -18,6 +18,9 @@ index 0000000000000000000000000000000000000000..22d119036d12c396af935fe85ae18751
 +  # Enable the V8 inspector protocol for use with node.
 +  node_enable_inspector = true
 +
++  # Enable diagnostic reporting withing Node.js
++  node_report = true
++
 +  # Build node with SSL support.
 +  # The variable is called "openssl" for parity with node's GYP build.
 +  node_use_openssl = true
@@ -123,6 +126,11 @@ index 0000000000000000000000000000000000000000..22d119036d12c396af935fe85ae18751
 +  } else {
 +    defines += [ "NODE_USE_V8_PLATFORM=0" ]
 +  }
++  if (node_report) {
++    defines += [ "NODE_REPORT=1" ]
++  } else {
++    defines += [ "NODE_REPORT=0" ]
++  }
 +}
 +
 +config("node_lib_config") {
@@ -254,6 +262,14 @@ index 0000000000000000000000000000000000000000..22d119036d12c396af935fe85ae18751
 +    libs += [ "CoreFoundation.framework" ]
 +  }
 +
++  if (node_report) {
++    sources += [
++      "src/node_report.cc",
++      "src/node_report_module.cc",
++      "src/node_report_utils.cc",
++    ]
++  }
++
 +  if (node_enable_inspector) {
 +    sources += [
 +      "src/inspector_agent.cc",

+ 0 - 6
script/node-disabled-tests.json

@@ -206,12 +206,6 @@
   "parallel/test-zlib-unused-weak",
   "pseudo-tty/test-set-raw-mode-reset-process-exit",
   "pseudo-tty/test-set-raw-mode-reset-signal",
-  "report/test-report-config",
-  "report/test-report-getreport",
-  "report/test-report-signal",
-  "report/test-report-uncaught-exception",
-  "report/test-report-writereport",
-  "report/test-report-worker",
   "sequential/test-child-process-execsync",
   "sequential/test-cpu-prof-default",
   "sequential/test-cpu-prof-dir-absolute",