Browse Source

make sure setparentwindow only shows the window if already visible

xaviergonz 8 years ago
parent
commit
d0c91daaed
1 changed files with 2 additions and 3 deletions
  1. 2 3
      atom/browser/native_window_mac.mm

+ 2 - 3
atom/browser/native_window_mac.mm

@@ -914,8 +914,7 @@ NativeWindowMac::NativeWindowMac(
 
   // Only use native parent window for non-modal windows.
   if (parent && !is_modal()) {
-    // It will be properly attached on show and detached on hide.
-    InternalSetParentWindow(parent, false);
+    SetParentWindow(parent);
   }
 
   if (transparent()) {
@@ -1566,7 +1565,7 @@ void NativeWindowMac::InternalSetParentWindow(NativeWindow* parent, bool attach)
 }
 
 void NativeWindowMac::SetParentWindow(NativeWindow* parent) {
-  InternalSetParentWindow(parent, true);
+  InternalSetParentWindow(parent, IsVisible());
 }
 
 gfx::NativeView NativeWindowMac::GetNativeView() const {