Browse Source

remove crashReporter deprecation

Shelley Vohr 7 years ago
parent
commit
cc30f4c4fd
2 changed files with 2 additions and 24 deletions
  1. 0 17
      docs/tutorial/planned-breaking-changes.md
  2. 2 7
      lib/common/api/crash-reporter.js

+ 0 - 17
docs/tutorial/planned-breaking-changes.md

@@ -29,23 +29,6 @@ window.on('app-command', (e, cmd) => {
 })
 ```
 
-## `crashReporter`
-
-```js
-// Deprecated
-crashReporter.start({
-  companyName: 'Crashly',
-  submitURL: 'https://crash.server.com',
-  autoSubmit: true
-})
-// Replace with
-crashReporter.start({
-  companyName: 'Crashly',
-  submitURL: 'https://crash.server.com',
-  uploadToServer: true
-})
-```
-
 ## `nativeImage`
 
 ```js

+ 2 - 7
lib/common/api/crash-reporter.js

@@ -4,7 +4,7 @@ const {spawn} = require('child_process')
 const os = require('os')
 const path = require('path')
 const electron = require('electron')
-const {app, deprecate} = process.type === 'browser' ? electron : electron.remote
+const {app} = process.type === 'browser' ? electron : electron.remote
 const binding = process.atomBinding('crash_reporter')
 
 class CrashReporter {
@@ -21,12 +21,7 @@ class CrashReporter {
     } = options
 
     if (uploadToServer == null) {
-      if (options.autoSubmit) {
-        deprecate.warn('autoSubmit', 'uploadToServer')
-        uploadToServer = options.autoSubmit
-      } else {
-        uploadToServer = true
-      }
+      uploadToServer = true
     }
 
     if (ignoreSystemCrashHandler == null) ignoreSystemCrashHandler = false