Browse Source

Notifications should emit close on close, not eventual GC

Matt Crocker 7 years ago
parent
commit
ca8f45a501
2 changed files with 2 additions and 2 deletions
  1. 1 1
      atom/browser/api/atom_api_notification.cc
  2. 1 1
      docs/api/notification.md

+ 1 - 1
atom/browser/api/atom_api_notification.cc

@@ -169,10 +169,10 @@ void Notification::NotificationDisplayed() {
 }
 
 void Notification::NotificationDestroyed() {
-  Emit("close");
 }
 
 void Notification::NotificationClosed() {
+  Emit("close");
 }
 
 // Showing notifications

+ 1 - 1
docs/api/notification.md

@@ -74,7 +74,7 @@ Returns:
 
 Emitted when the notification is closed by manual intervention from the user.
 
-This event is not guarunteed to be emitted in all cases where the notification
+This event is not guaranteed to be emitted in all cases where the notification
 is closed.
 
 #### Event: 'reply' _macOS_