Browse Source

chore: no need to expose Initialize of ipc module (#16066)

Cheng Zhao 6 years ago
parent
commit
c7aa747891

+ 11 - 7
atom/renderer/api/atom_api_renderer_ipc.cc

@@ -78,18 +78,22 @@ void SendTo(mate::Arguments* args,
     args->ThrowError("Unable to send AtomFrameHostMsg_Message_To");
 }
 
+}  // namespace api
+
+}  // namespace atom
+
+namespace {
+
 void Initialize(v8::Local<v8::Object> exports,
                 v8::Local<v8::Value> unused,
                 v8::Local<v8::Context> context,
                 void* priv) {
   mate::Dictionary dict(context->GetIsolate(), exports);
-  dict.SetMethod("send", &Send);
-  dict.SetMethod("sendSync", &SendSync);
-  dict.SetMethod("sendTo", &SendTo);
+  dict.SetMethod("send", &atom::api::Send);
+  dict.SetMethod("sendSync", &atom::api::SendSync);
+  dict.SetMethod("sendTo", &atom::api::SendTo);
 }
 
-}  // namespace api
-
-}  // namespace atom
+}  // namespace
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(atom_renderer_ipc, atom::api::Initialize)
+NODE_BUILTIN_MODULE_CONTEXT_AWARE(atom_renderer_ipc, Initialize)

+ 0 - 5
atom/renderer/api/atom_api_renderer_ipc.h

@@ -29,11 +29,6 @@ void SendTo(mate::Arguments* args,
             const std::string& channel,
             const base::ListValue& arguments);
 
-void Initialize(v8::Local<v8::Object> exports,
-                v8::Local<v8::Value> unused,
-                v8::Local<v8::Context> context,
-                void* priv);
-
 }  // namespace api
 
 }  // namespace atom