Browse Source

build: fix buildflags.h generation on macos (#27595)

Co-authored-by: John Kleinschmidt <[email protected]>
trop[bot] 4 years ago
parent
commit
c67c3aaf74
2 changed files with 2 additions and 4 deletions
  1. 0 4
      .circleci/config.yml
  2. 2 0
      BUILD.gn

+ 0 - 4
.circleci/config.yml

@@ -447,10 +447,6 @@ step-fix-sync-on-mac: &step-fix-sync-on-mac
         # Fix Clang Install (wrong binary)
         rm -rf src/third_party/llvm-build
         python src/tools/clang/scripts/update.py
-        # Temporarily use an older version of gn
-        unset CI
-        python src/buildtools/ensure_gn_version.py git_revision:53d92014bf94c3893886470a1c7c1289f8818db0
-        export CI=true
       fi
 
 step-install-signing-cert-on-mac: &step-install-signing-cert-on-mac

+ 2 - 0
BUILD.gn

@@ -991,6 +991,8 @@ if (is_mac) {
     deps = [
       ":electron_app_framework_bundle_data",
       ":electron_app_resources",
+      "//base",
+      "//electron/buildflags",
     ]
     if (is_mas_build) {
       deps += [ ":electron_login_helper_app" ]