Browse Source

spec: update callback registry spec to expect (#13263)

* spec: update callback-reg-spec to sexpect

* remove stray only

* remove redundant assertions
Shelley Vohr 6 years ago
parent
commit
c5c571f8ec
1 changed files with 11 additions and 12 deletions
  1. 11 12
      spec/api-callbacks-registry-spec.js

+ 11 - 12
spec/api-callbacks-registry-spec.js

@@ -1,4 +1,9 @@
-const {assert} = require('chai')
+const chai = require('chai')
+const dirtyChai = require('dirty-chai')
+
+const {expect} = chai
+chai.use(dirtyChai)
+
 const {CallbacksRegistry} = require('electron')
 
 describe('CallbacksRegistry module', () => {
@@ -12,7 +17,7 @@ describe('CallbacksRegistry module', () => {
     const cb = () => [1, 2, 3, 4, 5]
     const key = registry.add(cb)
 
-    assert.exists(key)
+    expect(key).to.exist()
   })
 
   it('returns a specified callback if it is in the registry', () => {
@@ -20,29 +25,23 @@ describe('CallbacksRegistry module', () => {
     const key = registry.add(cb)
     const callback = registry.get(key)
 
-    assert.equal(callback.toString(), cb.toString())
+    expect(callback.toString()).equal(cb.toString())
   })
 
   it('returns an empty function if the cb doesnt exist', () => {
     const callback = registry.get(1)
 
-    assert.isFunction(callback)
+    expect(callback).to.be.a('function')
   })
 
   it('removes a callback to the registry', () => {
     const cb = () => [1, 2, 3, 4, 5]
     const key = registry.add(cb)
 
-    assert.exists(key)
-
-    const beforeCB = registry.get(key)
-
-    assert.equal(beforeCB.toString(), cb.toString())
-
     registry.remove(key)
     const afterCB = registry.get(key)
 
-    assert.isFunction(afterCB)
-    assert.notEqual(afterCB.toString(), cb.toString())
+    expect(afterCB).to.be.a('function')
+    expect(afterCB.toString()).to.not.equal(cb.toString())
   })
 })