Browse Source

refactor: properly report on skipped native modules tests (#13894)

Jeremy Apthorp 6 years ago
parent
commit
c452be02b9
3 changed files with 5 additions and 14 deletions
  1. 2 4
      spec/api-browser-window-spec.js
  2. 1 3
      spec/modules-spec.js
  3. 2 7
      spec/webview-spec.js

+ 2 - 4
spec/api-browser-window-spec.js

@@ -1697,10 +1697,8 @@ describe('BrowserWindow module', () => {
           done()
         })
         w.loadURL(`file://${path.join(fixtures, 'api', 'native-window-open-iframe.html')}`)
-      })
-      it('loads native addons correctly after reload', (done) => {
-        if (!nativeModulesEnabled) return done()
-
+      });
+      (nativeModulesEnabled ? it : it.skip)('loads native addons correctly after reload', (done) => {
         ipcMain.once('answer', (event, content) => {
           assert.equal(content, 'function')
           ipcMain.once('answer', (event, content) => {

+ 1 - 3
spec/modules-spec.js

@@ -11,9 +11,7 @@ describe('modules support', () => {
   const fixtures = path.join(__dirname, 'fixtures')
 
   describe('third-party module', () => {
-    describe('runas', () => {
-      if (!nativeModulesEnabled) return
-
+    (nativeModulesEnabled ? describe : describe.skip)('runas', () => {
       it('can be required in renderer', () => {
         require('runas')
       })

+ 2 - 7
spec/webview-spec.js

@@ -204,14 +204,9 @@ describe('<webview> tag', function () {
         allowpopups: 'on',
         src
       })
-    })
-
-    it('loads native modules when navigation happens', async function () {
-      if (!nativeModulesEnabled) {
-        this.skip()
-        return
-      }
+    });
 
+    (nativeModulesEnabled ? it : it.skip)('loads native modules when navigation happens', async function () {
       await loadWebView(webview, {
         nodeintegration: 'on',
         src: `file://${fixtures}/pages/native-module.html`