Browse Source

Make killall Electron more friendly

John Kleinschmidt 6 years ago
parent
commit
bfaf3f458f
1 changed files with 7 additions and 3 deletions
  1. 7 3
      vsts.yml

+ 7 - 3
vsts.yml

@@ -131,6 +131,9 @@ jobs:
       mkdir -p src/out/ffmpeg
       git clone https://github.com/electron/electron src/electron
       (cd src/electron; git fetch origin +"${BUILD_SOURCEBRANCH}"; git checkout "${BUILD_SOURCEVERSION}")
+      cd src
+      export CHROMIUM_BUILDTOOLS_PATH=`pwd`/buildtools
+      echo "##vso[task.setvariable variable=CHROMIUM_BUILDTOOLS_PATH]`pwd`/buildtools"
     displayName: Checkout Electron
 
   - task: DownloadBuildArtifacts@0
@@ -143,7 +146,7 @@ jobs:
     displayName: 'Download ffmpeg.dylib for testing'
     inputs:
       artifactName: ffmpeg
-      downloadPath: '$(System.DefaultWorkingDirectory)/src/out/ffmpeg'
+      downloadPath: '$(System.DefaultWorkingDirectory)/src/out'
 
   - task: DownloadBuildArtifacts@0
     displayName: 'Download Node.js headers'
@@ -157,8 +160,9 @@ jobs:
     displayName: Unzip Electron app
 
   - bash: |
-      set +e
-      killall Electron
+      if pgrep Electron; then
+        killall Electron
+      fi
     displayName: Make sure Electron isn't running from previous tests
 
   - bash: |