Browse Source

Add codesigning certificate step

Shelley Vohr 1 year ago
parent
commit
bc36c67fa0
1 changed files with 5 additions and 21 deletions
  1. 5 21
      .github/workflows/mac-build.yml

+ 5 - 21
.github/workflows/mac-build.yml

@@ -509,24 +509,8 @@ jobs:
         unzip -:o dist.zip
         unzip -:o chromedriver.zip
         unzip -:o mksnapshot.zip
-    # - name: Import & Trust Self-Signed Codesigning Cert on MacOS
-    #   run: |
-    #     sudo security authorizationdb write com.apple.trust-settings.admin allow
-    #     cd src/electron
-    #     ./script/codesign/generate-identity.sh
-    # TODO(vertedinde): Does GHA support test-splitting?
-    # - name: Run Electron tests
-    #   env:
-    #     MOCHA_REPORTER: mocha-multi-reporters
-    #     ELECTRON_TEST_RESULTS_DIR: junit
-    #     MOCHA_MULTI_REPORTERS: mocha-junit-reporter, tap
-    #     ELECTRON_DISABLE_SECURITY_WARNINGS: 1
-    #   run: |
-    #     cd src
-    #     if [ "$TARGET_ARCH" == "arm" ] || [ "$TARGET_ARCH" == "arm64" ]; then
-    #       export ELECTRON_SKIP_NATIVE_MODULE_TESTS=true
-    #     fi
-    #     cd electron
-    #     e test
-    #     # (cd electron && (circleci tests glob "spec/*-spec.ts" | xargs -I@ -P4 bash -c "echo $(pwd)/@" | circleci tests run --command="xargs node script/yarn test --runners=main --trace-uncaught --enable-logging --files" --split-by=timings))
-  
+    - name: Import & Trust Self-Signed Codesigning Cert on MacOS
+      run: |
+        sudo security authorizationdb write com.apple.trust-settings.admin allow
+        cd src/electron
+        ./script/codesign/generate-identity.sh