Browse Source

fixme: C70 removed DidReceiveCompositorFrame

(OSR relatied)

refs: https://github.com/electron/electron/commit/1de1ca906a36adfde432190284f8c378118a3c94

cc @brenca
Samuel Attard 6 years ago
parent
commit
b6aae790cf
2 changed files with 13 additions and 11 deletions
  1. 11 10
      atom/browser/api/frame_subscriber.cc
  2. 2 1
      atom/browser/api/frame_subscriber.h

+ 11 - 10
atom/browser/api/frame_subscriber.cc

@@ -58,16 +58,17 @@ gfx::Rect FrameSubscriber::GetDamageRect() {
   }
 }
 
-void FrameSubscriber::DidReceiveCompositorFrame() {
-  auto* view = web_contents()->GetRenderWidgetHostView();
-  if (view == nullptr)
-    return;
-
-  view->CopyFromSurface(
-      gfx::Rect(), view->GetViewBounds().size(),
-      base::BindOnce(&FrameSubscriber::Done, weak_ptr_factory_.GetWeakPtr(),
-                     GetDamageRect()));
-}
+// FIXME(MarshallOfSound): Removed in C70
+// void FrameSubscriber::DidReceiveCompositorFrame() {
+//   auto* view = web_contents()->GetRenderWidgetHostView();
+//   if (view == nullptr)
+//     return;
+
+//   view->CopyFromSurface(
+//       gfx::Rect(), view->GetViewBounds().size(),
+//       base::BindOnce(&FrameSubscriber::Done, weak_ptr_factory_.GetWeakPtr(),
+//                      GetDamageRect()));
+// }
 
 void FrameSubscriber::Done(const gfx::Rect& damage, const SkBitmap& frame) {
   if (frame.drawsNothing())

+ 2 - 1
atom/browser/api/frame_subscriber.h

@@ -33,7 +33,8 @@ class FrameSubscriber : public content::WebContentsObserver {
 
  private:
   gfx::Rect GetDamageRect();
-  void DidReceiveCompositorFrame() override;
+  // FIXME(MarshallOfSound): Removed in C70
+  //   void DidReceiveCompositorFrame() override;
   void Done(const gfx::Rect& damage, const SkBitmap& frame);
 
   v8::Isolate* isolate_;