Browse Source

chore: update asar injection for new node internal module loader

Samuel Attard 6 years ago
parent
commit
b1e69e1357
2 changed files with 3 additions and 5 deletions
  1. 2 2
      atom/common/api/atom_api_asar.cc
  2. 1 3
      lib/common/asar_init.js

+ 2 - 2
atom/common/api/atom_api_asar.cc

@@ -119,7 +119,7 @@ class Archive : public mate::Wrappable<Archive> {
 };
 
 void InitAsarSupport(v8::Isolate* isolate,
-                     v8::Local<v8::Value> process,
+                     v8::Local<v8::Value> source,
                      v8::Local<v8::Value> require) {
   // Evaluate asar_init.js.
   v8::Local<v8::Context> context(isolate->GetCurrentContext());
@@ -134,7 +134,7 @@ void InitAsarSupport(v8::Isolate* isolate,
   CHECK(result->IsFunction());
 
   v8::Local<v8::Value> args[] = {
-      process,
+      source,
       require,
       node::asar_value.ToStringChecked(isolate),
   };

+ 1 - 3
lib/common/asar_init.js

@@ -1,9 +1,7 @@
 'use strict'
 
 ;(function () { // eslint-disable-line
-  return function (process, require, asarSource) {
-    const source = process.binding('natives')
-
+  return function (source, require, asarSource) {
     // Expose fs module without asar support.
     source['original-fs'] = source.fs