Browse Source

fix: gracefully fail if app.configureHostResolver is called before ready (#33062)

Jeremy Rose 3 years ago
parent
commit
aa8119515f
1 changed files with 5 additions and 0 deletions
  1. 5 0
      shell/browser/api/electron_api_app.cc

+ 5 - 0
shell/browser/api/electron_api_app.cc

@@ -1630,6 +1630,11 @@ v8::Local<v8::Value> App::GetDockAPI(v8::Isolate* isolate) {
 void ConfigureHostResolver(v8::Isolate* isolate,
                            const gin_helper::Dictionary& opts) {
   gin_helper::ErrorThrower thrower(isolate);
+  if (!Browser::Get()->is_ready()) {
+    thrower.ThrowError(
+        "configureHostResolver cannot be called before the app is ready");
+    return;
+  }
   net::SecureDnsMode secure_dns_mode = net::SecureDnsMode::kOff;
   std::string default_doh_templates;
   if (base::FeatureList::IsEnabled(features::kDnsOverHttps)) {