Browse Source

build: delete dsyms after they have been zipped in release builds

Samuel Attard 4 years ago
parent
commit
a76b53348c
2 changed files with 3 additions and 1 deletions
  1. 1 1
      .circleci/config.yml
  2. 2 0
      script/zip-symbols.py

+ 1 - 1
.circleci/config.yml

@@ -850,7 +850,7 @@ step-maybe-zip-symbols: &step-maybe-zip-symbols
       export BUILD_PATH="$PWD/out/Default"
       ninja -C out/Default electron:licenses
       ninja -C out/Default electron:electron_version
-      electron/script/zip-symbols.py -b $BUILD_PATH
+      DELETE_DSYMS_AFTER_ZIP=1 electron/script/zip-symbols.py -b $BUILD_PATH
 
 step-symbols-store: &step-symbols-store
   store_artifacts:

+ 2 - 0
script/zip-symbols.py

@@ -36,6 +36,8 @@ def main():
       dsym_zip_file = os.path.join(args.build_dir, dsym_name)
       print('Making dsym zip: ' + dsym_zip_file)
       make_zip(dsym_zip_file, licenses, dsyms)
+      if len(dsyms) > 0 and 'DELETE_DSYMS_AFTER_ZIP' in os.environ:
+        execute(['rm', '-rf'] + dsyms)
   elif PLATFORM == 'win32':
     pdb_name = 'pdb.zip'
     with scoped_cwd(args.build_dir):