Browse Source

Follow object naming conventions for params in the 'context-menu' event

Daniel Pham 9 years ago
parent
commit
a6f2d401fa

+ 1 - 1
atom/common/native_mate_converters/blink_converter.cc

@@ -324,7 +324,7 @@ v8::Local<v8::Value> Converter<blink::WebContextMenuData::InputFieldType>::ToV8(
       const blink::WebContextMenuData::InputFieldType& in) {
   switch (in) {
     case blink::WebContextMenuData::InputFieldTypePlainText:
-      return mate::StringToV8(isolate, "plain-text");
+      return mate::StringToV8(isolate, "plainText");
     case blink::WebContextMenuData::InputFieldTypePassword:
       return mate::StringToV8(isolate, "password");
     case blink::WebContextMenuData::InputFieldTypeOther:

+ 1 - 1
atom/common/native_mate_converters/ui_base_types_converter.h

@@ -22,7 +22,7 @@ struct Converter<ui::MenuSourceType> {
       case ui::MENU_SOURCE_TOUCH:
         return mate::StringToV8(isolate, "touch");
       case ui::MENU_SOURCE_TOUCH_EDIT_MENU:
-        return mate::StringToV8(isolate, "touch-menu");
+        return mate::StringToV8(isolate, "touchMenu");
       default:
         return mate::StringToV8(isolate, "none");
     }

+ 2 - 2
docs/api/web-contents.md

@@ -358,10 +358,10 @@ was invoked on.
   * `frameCharset` String - The character encoding of the frame on which the
 menu was invoked.
   * `inputFieldType` String - If the context menu was invoked on an input
-field, the type of that field. Possible values are `none`, `plain-text`,
+field, the type of that field. Possible values are `none`, `plainText`,
 `password`, `other`.
   * `menuSourceType` String - Input source that invoked the context menu.
-Can be `none`, `mouse`, `keyboard`, `touch`, `touch-menu`.
+Can be `none`, `mouse`, `keyboard`, `touch`, `touchMenu`.
 
 Emitted when there is a new context menu that needs to be handled.