Pchen0/electron

chore: use --root instead of --project_root for cpplint (#34474)

--root has been improved upstream in depot_tools to better handle Windows:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3648533

Co-authored-by: David Sanders <[email protected]>

trop[bot] 2 years ago

parent

69179bbfe7

commit

a4a9210d2d

1 changed files with 1 additions and 1 deletions

Split View Show Diff Stats

						
							+ 1
							
							- 1
						
script/lint.js
							 
								View File
							
				@@ -44,7 +44,7 @@ function spawnAndCheckExitCode (cmd, args, opts) {
			
				 }
			
				 function cpplint (args) {
			
				-  args.unshift(`--project_root=${SOURCE_ROOT}`);
			
				+  args.unshift(`--root=${SOURCE_ROOT}`);
			
				   const result = childProcess.spawnSync(IS_WINDOWS ? 'cpplint.bat' : 'cpplint.py', args, { encoding: 'utf8', shell: true });
			
				   // cpplint.py writes EVERYTHING to stderr, including status messages
			
				   if (result.stderr) {

chore: use --root instead of --project_root for cpplint (#34474)

+ 1 - 1 script/lint.js View File

+ 1 - 1
script/lint.js
View File