Browse Source

Change qualifier of ShowSaveDialog() parameter

The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
Tan Wang Leng 8 years ago
parent
commit
a4a71a1dc9

+ 1 - 1
atom/browser/api/atom_api_dialog.cc

@@ -95,7 +95,7 @@ void ShowSaveDialog(const std::string& title,
                     const file_dialog::Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     atom::NativeWindow* window,
                     mate::Arguments* args) {
   v8::Local<v8::Value> peek = args->PeekNext();

+ 2 - 2
atom/browser/ui/file_dialog.h

@@ -62,7 +62,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     base::FilePath* path);
 
 void ShowSaveDialog(atom::NativeWindow* parent_window,
@@ -72,7 +72,7 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     const SaveDialogCallback& callback);
 
 }  // namespace file_dialog

+ 2 - 2
atom/browser/ui/file_dialog_gtk.cc

@@ -279,7 +279,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     base::FilePath* path) {
   FileChooserDialog save_dialog(GTK_FILE_CHOOSER_ACTION_SAVE, parent_window,
                                 title, button_label, default_path, filters);
@@ -300,7 +300,7 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     const SaveDialogCallback& callback) {
   FileChooserDialog* save_dialog = new FileChooserDialog(
       GTK_FILE_CHOOSER_ACTION_SAVE, parent_window, title, button_label,

+ 2 - 2
atom/browser/ui/file_dialog_mac.mm

@@ -191,7 +191,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     base::FilePath* path) {
   DCHECK(path);
   NSSavePanel* dialog = [NSSavePanel savePanel];
@@ -214,7 +214,7 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     const SaveDialogCallback& c) {
   NSSavePanel* dialog = [NSSavePanel savePanel];
 

+ 2 - 2
atom/browser/ui/file_dialog_win.cc

@@ -272,7 +272,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     base::FilePath* path) {
   FileDialog<CShellFileSaveDialog> save_dialog(
       default_path, title, button_label, filters,
@@ -296,7 +296,7 @@ void ShowSaveDialog(atom::NativeWindow* parent,
                     const Filters& filters,
                     const std::string& message,
                     const std::string& name_field_label,
-                    const bool& shows_tag_field,
+                    bool shows_tag_field,
                     const SaveDialogCallback& callback) {
   RunState run_state;
   if (!CreateDialogThread(&run_state)) {