Browse Source

fix: `webContents.print()` crash on Linux (#46147)

fix: webContents.print() crash on Linux

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
trop[bot] 1 month ago
parent
commit
a29490a4e8
1 changed files with 12 additions and 0 deletions
  1. 12 0
      shell/browser/feature_list.cc

+ 12 - 0
shell/browser/feature_list.cc

@@ -27,6 +27,10 @@
 #include "pdf/pdf_features.h"
 #endif
 
+#if BUILDFLAG(IS_LINUX)
+#include "printing/printing_features.h"
+#endif
+
 namespace electron {
 
 void InitializeFeatureList() {
@@ -56,6 +60,14 @@ void InitializeFeatureList() {
       std::string(",") + features::kMacWebContentsOcclusion.name;
 #endif
 
+#if BUILDFLAG(IS_LINUX)
+  disable_features +=
+      // EnableOopPrintDrivers is still a bit half-baked on Linux and
+      // causes crashes when trying to show dialogs.
+      // TODO(codebytere): figure out how to re-enable this with our patches.
+      std::string(",") + printing::features::kEnableOopPrintDrivers.name;
+#endif
+
 #if BUILDFLAG(ENABLE_PDF_VIEWER)
   // Enable window.showSaveFilePicker api for saving pdf files.
   // Refs https://issues.chromium.org/issues/373852607