Home Explore 引导页 在线工具 Blog
Register Sign In
Pchen0
/
electron
1
0
Fork 0
Files Issues 0 Pull Requests 0 Wiki
Browse Source

Add failing spec for native window.open returning null without allowpopups

Kevin Sawicki 8 years ago
parent
4e9efebf47
commit
a0571e3c72
2 changed files with 19 additions and 0 deletions
Split View Show Diff Stats
  1. 9 0
      spec/fixtures/api/native-window-open-no-allowpopups.html
  2. 10 0
      spec/webview-spec.js

+ 9 - 0
spec/fixtures/api/native-window-open-no-allowpopups.html
View File 

@@ -0,0 +1,9 @@
 
+<html>
 
+<body>
 
+<script type="text/javascript" charset="utf-8">
 
+  const {ipcRenderer} = require('electron')
 
+  const popup = window.open()
 
+  ipcRenderer.send('answer', {windowOpenReturnedNull: popup == null})
 
+</script>
 
+</body>
 
+</html>

+ 10 - 0
spec/webview-spec.js
View File 

@@ -1676,6 +1676,16 @@ describe('<webview> tag', function () {
 
       document.body.appendChild(webview)
 
     })
 
 
+    it('returns null from window.open when allowpopups is not set', (done) => {
 
+      webview.removeAttribute('allowpopups')
 
+      ipcMain.once('answer', (event, {windowOpenReturnedNull}) => {
 
+        assert.equal(windowOpenReturnedNull, true)
 
+        done()
 
+      })
 
+      webview.src = 'file://' + path.join(fixtures, 'api', 'native-window-open-no-allowpopups.html')
 
+      document.body.appendChild(webview)
 
+    })
 
+
 
     it('emits a new-window event', (done) => {
 
       webview.addEventListener('new-window', function (e) {
 
         assert.equal(e.url, 'http://host/')