Browse Source

fix remote setInterval flake (#12263)

Samuel Attard 7 years ago
parent
commit
9ed9885c8d
1 changed files with 5 additions and 1 deletions
  1. 5 1
      spec/node-spec.js

+ 5 - 1
spec/node-spec.js

@@ -184,11 +184,15 @@ describe('node feature', () => {
     describe('setInterval called under Chromium event loop in browser process', () => {
       it('can be scheduled in time', (done) => {
         let interval = null
+        let clearing = false
         const clear = () => {
-          if (interval === null) {
+          if (interval === null || clearing) {
             return
           }
+          // interval might trigger while clearing (remote is slow sometimes)
+          clearing = true
           remote.getGlobal('clearInterval')(interval)
+          clearing = false
           interval = null
           done()
         }