Browse Source

Merge pull request #9516 from electron/flaky-pid-test

Assert OS pid after load finishes
Kevin Sawicki 8 years ago
parent
commit
9ce3a8c3a7
1 changed files with 7 additions and 4 deletions
  1. 7 4
      spec/api-web-contents-spec.js

+ 7 - 4
spec/api-web-contents-spec.js

@@ -325,13 +325,16 @@ describe('webContents module', function () {
   })
 
   describe('getOSProcessId()', function () {
-    it('returns a valid procress id', function () {
+    it('returns a valid procress id', function (done) {
       assert.strictEqual(w.webContents.getOSProcessId(), 0)
 
+      w.webContents.once('did-finish-load', () => {
+        const pid = w.webContents.getOSProcessId()
+        assert.equal(typeof pid, 'number')
+        assert(pid > 0, `pid ${pid} is not greater than 0`)
+        done()
+      })
       w.loadURL('about:blank')
-      const pid = w.webContents.getOSProcessId()
-      assert(typeof pid === 'number', 'is a number')
-      assert(pid > 0, 'superior to 0')
     })
   })