Browse Source

Made `NotificationDelegateImpl` final

The class is designed to call `delete` on itself and because it doesn't have
a virtual destructor, it shouldn't be derived from.
Ales Pergl 7 years ago
parent
commit
9ca658238b
1 changed files with 1 additions and 1 deletions
  1. 1 1
      brightray/browser/platform_notification_service.cc

+ 1 - 1
brightray/browser/platform_notification_service.cc

@@ -45,7 +45,7 @@ void OnWebNotificationAllowed(base::WeakPtr<Notification> notification,
   }
 }
 
-class NotificationDelegateImpl : public brightray::NotificationDelegate {
+class NotificationDelegateImpl final : public brightray::NotificationDelegate {
  public:
   explicit NotificationDelegateImpl(const std::string& notification_id)
       : notification_id_(notification_id) {}