Browse Source

fix: enable inputpane virtual keyboard by default (#16944)

backports e6c18518b from chromium, fixes #13832
Jeremy Apthorp 6 years ago
parent
commit
969ac4ced1

+ 1 - 0
patches/common/chromium/.patches

@@ -90,3 +90,4 @@ sqlite_upgrade_from_3_24_to_3_26.patch
 sqlite_update_api_3_26.patch
 tts.patch
 do_not_allow_impl_side_invalidations_until_frame_sink_is_fully_active.patch
+enable_inputpane_virtual_keyboard_functionality_by_default.patch

+ 29 - 0
patches/common/chromium/enable_inputpane_virtual_keyboard_functionality_by_default.patch

@@ -0,0 +1,29 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Dave Tapuska <[email protected]>
+Date: Mon, 11 Jun 2018 19:26:48 +0000
+Subject: Enable InputPane virtual keyboard functionality by default.
+
+Flip feature flag on. New functionality is used for Windows 10 RS4 and
+later.
+
+BUG=817501
+
+Change-Id: I3c45ac35f925a3b72f2ff50d5f8fdad4895b3cfd
+Reviewed-on: https://chromium-review.googlesource.com/946928
+Commit-Queue: Dave Tapuska <[email protected]>
+Reviewed-by: Scott Violet <[email protected]>
+Cr-Commit-Position: refs/heads/master@{#566102}
+
+diff --git a/ui/base/ui_base_features.cc b/ui/base/ui_base_features.cc
+index a2431e836940c4a1fc7fc95f128a2e2d5aab1b02..80add9507320a8e0dfb42f024095870faa7b3e3c 100644
+--- a/ui/base/ui_base_features.cc
++++ b/ui/base/ui_base_features.cc
+@@ -97,7 +97,7 @@ const base::Feature kUiCompositorScrollWithLayers = {
+ #if defined(OS_WIN)
+ // Enables InputPane API for controlling on screen keyboard.
+ const base::Feature kInputPaneOnScreenKeyboard = {
+-    "InputPaneOnScreenKeyboard", base::FEATURE_DISABLED_BY_DEFAULT};
++    "InputPaneOnScreenKeyboard", base::FEATURE_ENABLED_BY_DEFAULT};
+ 
+ // Enables using WM_POINTER instead of WM_TOUCH for touch events.
+ const base::Feature kPointerEventsForTouch = {"PointerEventsForTouch",