Browse Source

Merge pull request #2515 from atom/fix-no-print-background

Fix a typing error in option checking: printBackgrounds => printBackground
Cheng Zhao 9 years ago
parent
commit
8cc602ff94

+ 1 - 1
atom/browser/api/lib/web-contents.coffee

@@ -97,7 +97,7 @@ wrapWebContents = (webContents) ->
       printingSetting.marginsType = options.marginsType
     if options.printSelectionOnly
       printingSetting.shouldPrintSelectionOnly = options.printSelectionOnly
-    if options.printBackgrounds
+    if options.printBackground
       printingSetting.shouldPrintBackgrounds = options.printBackground
 
     if options.pageSize and PDFPageSize[options.pageSize]

+ 1 - 1
docs/api/browser-window-ko.md

@@ -992,7 +992,7 @@ Prints windows' web page as PDF with Chromium's preview printing custom
 settings.
 
 By default, an empty `options` will be regarded as
-`{marginsType:0, printBackgrounds:false, printSelectionOnly:false,
+`{marginsType:0, printBackground:false, printSelectionOnly:false,
   landscape:false}`.
 
 ```javascript

+ 1 - 1
docs/api/browser-window.md

@@ -1064,7 +1064,7 @@ Prints windows' web page as PDF with Chromium's preview printing custom
 settings.
 
 By default, an empty `options` will be regarded as
-`{marginsType:0, printBackgrounds:false, printSelectionOnly:false,
+`{marginsType:0, printBackground:false, printSelectionOnly:false,
   landscape:false}`.
 
 ```javascript