Browse Source

fix: allow maximizing when window enters tablet mode with WCO (#35664)

* fix: Backport CL 3753528 for WCO

* Update comment

* Update shell/browser/ui/views/win_caption_button_container.cc

Co-authored-by: Robo <[email protected]>

Co-authored-by: Raymond Zhao <[email protected]>
Co-authored-by: Robo <[email protected]>
trop[bot] 2 years ago
parent
commit
8becf52f11
1 changed files with 4 additions and 3 deletions
  1. 4 3
      shell/browser/ui/views/win_caption_button_container.cc

+ 4 - 3
shell/browser/ui/views/win_caption_button_container.cc

@@ -159,10 +159,11 @@ void WinCaptionButtonContainer::UpdateButtons() {
   const bool is_touch = ui::TouchUiController::Get()->touch_ui();
   restore_button_->SetEnabled(!is_touch);
 
-  // The maximize button should only be enabled if the window is
-  // maximizable *and* touch mode is disabled.
+  // In touch mode, windows cannot be taken out of fullscreen or tiled mode, so
+  // the maximize/restore button should be disabled, unless the window is not
+  // maximized.
   const bool maximizable = frame_view_->window()->IsMaximizable();
-  maximize_button_->SetEnabled(!is_touch && maximizable);
+  maximize_button_->SetEnabled(!(is_touch && is_maximized) && maximizable);
 
   const bool closable = frame_view_->window()->IsClosable();
   close_button_->SetEnabled(closable);