Browse Source

build: simplify unicode console output (#20017)

Shelley Vohr 5 years ago
parent
commit
7d4e0ad7b0

+ 2 - 2
script/lib/utils.js

@@ -6,8 +6,8 @@ const ELECTRON_DIR = path.resolve(__dirname, '..', '..')
 const SRC_DIR = path.resolve(ELECTRON_DIR, '..')
 
 require('colors')
-const pass = '\u2713'.green
-const fail = '\u2717'.red
+const pass = ''.green
+const fail = ''.red
 
 function getElectronExec () {
   const OUT_DIR = getOutDir()

+ 2 - 2
script/release/prepare-release.js

@@ -19,8 +19,8 @@ const bumpType = args._[0]
 const targetRepo = bumpType === 'nightly' ? 'nightlies' : 'electron'
 
 require('colors')
-const pass = '\u2713'.green
-const fail = '\u2717'.red
+const pass = ''.green
+const fail = ''.red
 
 if (!bumpType && !args.notesOnly) {
   console.log(`Usage: prepare-release [stable | beta | nightly]` +

+ 4 - 4
script/release/release-artifact-cleanup.js

@@ -1,13 +1,11 @@
 #!/usr/bin/env node
 
 if (!process.env.CI) require('dotenv-safe').load()
-require('colors')
-const pass = '\u2713'.green
-const fail = '\u2717'.red
 const args = require('minimist')(process.argv.slice(2), {
   string: ['tag', 'releaseID'],
   default: { releaseID: '' }
 })
+const path = require('path')
 const { execSync } = require('child_process')
 const { GitProcess } = require('dugite')
 const { getCurrentBranch, ELECTRON_DIR } = require('../lib/utils.js')
@@ -16,7 +14,9 @@ const octokit = require('@octokit/rest')({
   auth: process.env.ELECTRON_GITHUB_TOKEN
 })
 
-const path = require('path')
+require('colors')
+const pass = '✓'.green
+const fail = '✗'.red
 
 function getLastBumpCommit (tag) {
   const data = execSync(`git log -n1 --grep "Bump ${tag}" --format='format:{"hash": "%H", "message": "%s"}'`).toString()

+ 5 - 3
script/release/release.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 
 if (!process.env.CI) require('dotenv-safe').load()
-require('colors')
+
 const args = require('minimist')(process.argv.slice(2), {
   boolean: [
     'validateRelease',
@@ -17,13 +17,15 @@ const nugget = require('nugget')
 const got = require('got')
 const pkg = require('../../package.json')
 const pkgVersion = `v${pkg.version}`
-const pass = '\u2713'.green
 const path = require('path')
-const fail = '\u2717'.red
 const sumchecker = require('sumchecker')
 const temp = require('temp').track()
 const { URL } = require('url')
 
+require('colors')
+const pass = '✓'.green
+const fail = '✗'.red
+
 const { ELECTRON_DIR } = require('../lib/utils')
 
 const octokit = require('@octokit/rest')({

+ 2 - 2
script/spec-runner.js

@@ -8,8 +8,8 @@ const path = require('path')
 const unknownFlags = []
 
 require('colors')
-const pass = '\u2713'.green
-const fail = '\u2717'.red
+const pass = ''.green
+const fail = ''.red
 
 const args = require('minimist')(process.argv, {
   string: ['runners'],