Browse Source

Run more crashReporter specs on CI

Kevin Sawicki 8 years ago
parent
commit
77fa7ce977
2 changed files with 6 additions and 9 deletions
  1. 4 5
      spec/api-crash-reporter-spec.js
  2. 2 4
      spec/chromium-spec.js

+ 4 - 5
spec/api-crash-reporter-spec.js

@@ -9,6 +9,8 @@ const {closeWindow} = require('./window-helpers')
 const {remote} = require('electron')
 const {app, BrowserWindow, crashReporter} = remote.require('electron')
 
+const isCI = remote.getGlobal('isCi')
+
 describe('crashReporter module', function () {
   var fixtures = path.resolve(__dirname, 'fixtures')
   var w = null
@@ -33,12 +35,9 @@ describe('crashReporter module', function () {
     return
   }
 
-  var isCI = remote.getGlobal('isCi')
-  if (isCI) {
-    return
-  }
-
   it('should send minidump when renderer crashes', function (done) {
+    if (isCi) return
+
     this.timeout(120000)
 
     var called = false

+ 2 - 4
spec/chromium-spec.js

@@ -61,11 +61,9 @@ describe('chromium feature', function () {
       w.loadURL(url)
     })
 
-    if (isCI && process.platform === 'win32') {
-      return
-    }
-
     it('is set correctly when window is inactive', function (done) {
+      if (isCI && process.platform === 'win32') return done()
+
       w = new BrowserWindow({
         show: false
       })