Browse Source

fix: uaf in WebContents::DidStopLoading (#26702)

Jeremy Rose 4 years ago
parent
commit
770e245de5
1 changed files with 2 additions and 2 deletions
  1. 2 2
      shell/browser/api/electron_api_web_contents.cc

+ 2 - 2
shell/browser/api/electron_api_web_contents.cc

@@ -1447,12 +1447,12 @@ void WebContents::DidStartLoading() {
 }
 
 void WebContents::DidStopLoading() {
-  Emit("did-stop-loading");
-
   auto* web_preferences = WebContentsPreferences::From(web_contents());
   if (web_preferences &&
       web_preferences->IsEnabled(options::kEnablePreferredSizeMode))
     web_contents()->GetRenderViewHost()->EnablePreferredSizeMode();
+
+  Emit("did-stop-loading");
 }
 
 bool WebContents::EmitNavigationEvent(