Browse Source

build: fixup mksnapshot args on linux (#36782)

* build: fixup mksnapshot args on linux

(cherry picked from commit 8f134d7429269740ce4f7ed17f5203c83efab322)

* build: completely remove turbo profiling input
John Kleinschmidt 2 years ago
parent
commit
763daa8707
2 changed files with 5 additions and 3 deletions
  1. 3 3
      .circleci/config/base.yml
  2. 2 0
      build/args/all.gn

+ 3 - 3
.circleci/config/base.yml

@@ -575,7 +575,7 @@ step-electron-build: &step-electron-build
         ninja -C out/Default tools/v8_context_snapshot -j $NUMBER_OF_NINJA_PROCESSES
         gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args
         # Remove unused args from mksnapshot_args
-        SEDOPTION=
+        SEDOPTION="-i"
         if [ "`uname`" == "Darwin" ]; then
           SEDOPTION="-i ''"
         fi
@@ -772,7 +772,7 @@ step-mksnapshot-build: &step-mksnapshot-build
         ninja -C out/Default electron:electron_mksnapshot -j $NUMBER_OF_NINJA_PROCESSES
         gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args
         # Remove unused args from mksnapshot_args
-        SEDOPTION=
+        SEDOPTION="-i"
         if [ "`uname`" == "Darwin" ]; then
           SEDOPTION="-i ''"
         fi
@@ -2209,4 +2209,4 @@ workflows:
     jobs:
       - lint
 
-# VS Code Extension Version: 1.1.1
+# VS Code Extension Version: 1.4.0

+ 2 - 0
build/args/all.gn

@@ -48,3 +48,5 @@ is_cfi = false
 
 # TODO: fix this once sysroots have been updated.
 use_qt = false
+
+v8_builtins_profiling_log_file = ""