Browse Source

update reviewed items

Shelley Vohr 7 years ago
parent
commit
7593bec687
2 changed files with 6 additions and 11 deletions
  1. 3 8
      lib/browser/desktop-capturer.js
  2. 3 3
      lib/renderer/api/desktop-capturer.js

+ 3 - 8
lib/browser/desktop-capturer.js

@@ -30,7 +30,6 @@ ipcMain.on(electronSources, (event, captureWindow, captureScreen, thumbnailSize,
   // reference from requestsQueue to make the module not send the result to it.
   event.sender.once('destroyed', () => {
     request.webContents = null
-    return
   })
 })
 
@@ -48,19 +47,15 @@ desktopCapturer.emit = (event, name, sources) => {
     }
   })
 
-  if (handledWebContents != null) {
+  if (handledWebContents) {
     handledWebContents.send(capturerResult(handledRequest.id), result)
   }
 
-  // Check the queue to see whether there is other same request. If has, handle
-  // it for reducing redunplicated `desktopCaptuer.startHandling` calls.
-
+  // Check the queue to see whether there is another identical request & handle
   requestsQueue.forEach(request => {
     const webContents = request.webContents
     if (deepEqual(handledRequest.options, request.options)) {
-      if (webContents != null) {
-        webContents.send(capturerResult(request.id), result)
-      }
+      if (webContents) webContents.send(capturerResult(request.id), result)
     } else {
       unhandledRequestsQueue.push(request)
     }

+ 3 - 3
lib/renderer/api/desktop-capturer.js

@@ -8,10 +8,10 @@ const incrementId = () => {
   return currentId
 }
 
-// |options.type| can not be empty and has to include 'window' or 'screen'.
+// |options.types| can't be empty and must be an array
 function isValid (options) {
-  const types = (options != null) ? options.types : undefined
-  return (types != null) && Array.isArray(options.types)
+  const types = options ? options.types : undefined
+  return Array.isArray(types)
 }
 
 exports.getSources = function (options, callback) {