Browse Source

fix: handle edge behavior for about panel on Linux (#19634)

Erick Zhao 5 years ago
parent
commit
753501442f
1 changed files with 3 additions and 2 deletions
  1. 3 2
      atom/browser/browser_linux.cc

+ 3 - 2
atom/browser/browser_linux.cc

@@ -145,7 +145,8 @@ bool Browser::IsUnityRunning() {
 void Browser::ShowAboutPanel() {
   std::string app_name, version, copyright, icon_path, website;
 
-  GtkAboutDialog* dialog = GTK_ABOUT_DIALOG(gtk_about_dialog_new());
+  GtkWidget* dialogWidget = gtk_about_dialog_new();
+  GtkAboutDialog* dialog = GTK_ABOUT_DIALOG(dialogWidget);
 
   if (about_panel_options_.GetString("applicationName", &app_name))
     gtk_about_dialog_set_program_name(dialog, app_name.c_str());
@@ -173,7 +174,7 @@ void Browser::ShowAboutPanel() {
   }
 
   gtk_dialog_run(GTK_DIALOG(dialog));
-  g_clear_object(&dialog);
+  gtk_widget_destroy(dialogWidget);
 }
 
 void Browser::SetAboutPanelOptions(const base::DictionaryValue& options) {