Browse Source

chore: return early on promise rejection (#29537)

Co-authored-by: David Sanders <[email protected]>
trop[bot] 3 years ago
parent
commit
74216ec38b
1 changed files with 1 additions and 0 deletions
  1. 1 0
      shell/browser/api/electron_api_cookies.cc

+ 1 - 0
shell/browser/api/electron_api_cookies.cc

@@ -293,6 +293,7 @@ v8::Local<v8::Promise> Cookies::Set(v8::Isolate* isolate,
   const std::string* url_string = details.FindStringKey("url");
   if (!url_string) {
     promise.RejectWithErrorMessage("Missing required option 'url'");
+    return handle;
   }
   const std::string* name = details.FindStringKey("name");
   const std::string* value = details.FindStringKey("value");