Browse Source

docs: add missing vibrancy breaking change (#40906)

* docs: add missing vibranch change

Co-authored-by: Shelley Vohr <[email protected]>

* chore: update patches

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
trop[bot] 1 year ago
parent
commit
73197a85e2

+ 12 - 0
docs/breaking-changes.md

@@ -155,6 +155,18 @@ systemPreferences.on('high-contrast-color-scheme-changed', () => { /* ... */ })
 nativeTheme.on('updated', () => { /* ... */ })
 ```
 
+### Removed: Some `window.setVibrancy` options on macOS
+
+The following vibrancy options have been removed:
+
+* 'light'
+* 'medium-light'
+* 'dark'
+* 'ultra-dark'
+* 'appearance-based'
+
+These were previously deprecated and have been removed by Apple in 10.15.
+
 ### Removed: `webContents.getPrinters`
 
 The `webContents.getPrinters` method has been removed. Use

+ 0 - 1
patches/chromium/.patches

@@ -141,5 +141,4 @@ revert_same_party_cookie_attribute_removal.patch
 fix_restore_original_resize_performance_on_macos.patch
 fix_font_flooding_in_dev_tools.patch
 feat_allow_code_cache_in_custom_schemes.patch
-cherry-pick-8d607d3921b8.patch
 enable_partition_alloc_ref_count_size.patch

+ 0 - 33
patches/chromium/cherry-pick-8d607d3921b8.patch

@@ -1,33 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Gustaf Ullberg <[email protected]>
-Date: Wed, 20 Dec 2023 16:59:29 +0000
-Subject: WebRtcAudioSink: Stop on invalid configuration
-
-(cherry picked from commit 340b7e300d380460a039a07b90f62d1febae9da5)
-
-Bug: 1513170
-Change-Id: Ia4ca55e9eafb81789b28b8b8c54e615ac28df633
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5136295
-Reviewed-by: Harald Alvestrand <[email protected]>
-Commit-Queue: Gustaf Ullberg <[email protected]>
-Cr-Original-Commit-Position: refs/heads/main@{#1239233}
-Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5136708
-Owners-Override: Krishna Govind <[email protected]>
-Commit-Queue: Krishna Govind <[email protected]>
-Reviewed-by: Krishna Govind <[email protected]>
-Cr-Commit-Position: refs/branch-heads/6099@{#1566}
-Cr-Branched-From: e6ee4500f7d6549a9ac1354f8d056da49ef406be-refs/heads/main@{#1217362}
-
-diff --git a/third_party/blink/renderer/platform/peerconnection/webrtc_audio_sink.cc b/third_party/blink/renderer/platform/peerconnection/webrtc_audio_sink.cc
-index cd5b8b83ce3904f0d13152627602a57b2af116cf..de4a661d6322220ed04c471a14570e91f3f76896 100644
---- a/third_party/blink/renderer/platform/peerconnection/webrtc_audio_sink.cc
-+++ b/third_party/blink/renderer/platform/peerconnection/webrtc_audio_sink.cc
-@@ -121,7 +121,7 @@ void WebRtcAudioSink::OnData(const media::AudioBus& audio_bus,
- }
- 
- void WebRtcAudioSink::OnSetFormat(const media::AudioParameters& params) {
--  DCHECK(params.IsValid());
-+  CHECK(params.IsValid());
-   SendLogMessage(base::StringPrintf("OnSetFormat([label=%s] {params=[%s]})",
-                                     adapter_->label().c_str(),
-                                     params.AsHumanReadableString().c_str()));