Browse Source

refactor: do not use `AdaptCallbackForRepeating()` in `electron_api_url_loader.cc` (#45771)

refactor: do not use AdaptCallbackForRepeating in electron_api_url_loader.cc
Charles Kerr 1 month ago
parent
commit
69eb076bca

+ 2 - 3
shell/common/api/electron_api_url_loader.cc

@@ -438,7 +438,7 @@ void SimpleURLLoaderWrapper::OnAuthRequired(
             net::AuthCredentials(username_str, password_str));
       },
       std::move(auth_responder));
-  Emit("login", auth_info, base::AdaptCallbackForRepeating(std::move(cb)));
+  Emit("login", auth_info, std::move(cb));
 }
 
 void SimpleURLLoaderWrapper::OnSSLCertificateError(
@@ -716,8 +716,7 @@ void SimpleURLLoaderWrapper::OnDataReceived(std::string_view string_view,
   v8::HandleScope handle_scope(isolate);
   auto array_buffer = v8::ArrayBuffer::New(isolate, string_view.size());
   memcpy(array_buffer->Data(), string_view.data(), string_view.size());
-  Emit("data", array_buffer,
-       base::AdaptCallbackForRepeating(std::move(resume)));
+  Emit("data", array_buffer, std::move(resume));
 }
 
 void SimpleURLLoaderWrapper::OnComplete(bool success) {

+ 1 - 0
shell/common/gin_helper/event_emitter_caller.h

@@ -11,6 +11,7 @@
 #include "base/containers/span.h"
 #include "gin/converter.h"
 #include "gin/wrappable.h"
+#include "shell/common/gin_converters/std_converter.h"  // for ConvertToV8(iso, &&)
 
 namespace gin_helper {