Browse Source

build: always use python3 in `script/lib/get-version.js` (#45441)

build: always use python3 in script/lib/get-version.js

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <[email protected]>
trop[bot] 2 months ago
parent
commit
69333ae82f
2 changed files with 2 additions and 3 deletions
  1. 1 0
      .github/workflows/pipeline-segment-electron-test.yml
  2. 1 3
      script/lib/get-version.js

+ 1 - 0
.github/workflows/pipeline-segment-electron-test.yml

@@ -74,6 +74,7 @@ jobs:
         echo "C:\Program Files\Git\cmd" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
         echo "C:\Program Files\Git\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
         echo "C:\Python311" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+        cp "C:\Python311\python.exe" "C:\Python311\python3.exe"
     - name: Setup Node.js/npm
       if: ${{ inputs.target-platform == 'win' }}
       uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6

+ 1 - 3
script/lib/get-version.js

@@ -19,10 +19,8 @@ module.exports.getElectronVersion = () => {
     // Error may happen when trying to get version before running gn, which is a
     // valid case and error will be ignored.
   }
-  // Most win32 machines have python.exe but no python3.exe.
-  const python = process.platform === 'win32' ? 'python.exe' : 'python3';
   // Get the version from git tag if it is not defined in gn args.
-  const output = spawnSync(python, [path.join(ELECTRON_DIR, 'script', 'get-git-version.py')]);
+  const output = spawnSync('python3', [path.join(ELECTRON_DIR, 'script', 'get-git-version.py')]);
   if (output.status !== 0) {
     throw new Error(`Failed to get git tag, script quit with ${output.status}: ${output.stdout}`);
   }