Browse Source

fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole (#30356)

* fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole

* just delete the method

Co-authored-by: Jeremy Rose <[email protected]>
trop[bot] 3 years ago
parent
commit
6765eec7a9

+ 0 - 14
shell/browser/ui/inspectable_web_contents.cc

@@ -971,20 +971,6 @@ void InspectableWebContents::WebContentsDestroyed() {
     view_->GetDelegate()->DevToolsClosed();
 }
 
-bool InspectableWebContents::DidAddMessageToConsole(
-    content::WebContents* source,
-    blink::mojom::ConsoleMessageLevel level,
-    const std::u16string& message,
-    int32_t line_no,
-    const std::u16string& source_id) {
-  logging::LogMessage("CONSOLE", line_no,
-                      blink::ConsoleMessageLevelToLogSeverity(level))
-          .stream()
-      << "\"" << message << "\", source: " << source_id << " (" << line_no
-      << ")";
-  return true;
-}
-
 bool InspectableWebContents::HandleKeyboardEvent(
     content::WebContents* source,
     const content::NativeWebKeyboardEvent& event) {

+ 0 - 5
shell/browser/ui/inspectable_web_contents.h

@@ -175,11 +175,6 @@ class InspectableWebContents
       content::NavigationHandle* navigation_handle) override;
 
   // content::WebContentsDelegate:
-  bool DidAddMessageToConsole(content::WebContents* source,
-                              blink::mojom::ConsoleMessageLevel level,
-                              const std::u16string& message,
-                              int32_t line_no,
-                              const std::u16string& source_id) override;
   bool HandleKeyboardEvent(content::WebContents*,
                            const content::NativeWebKeyboardEvent&) override;
   void CloseContents(content::WebContents* source) override;