Browse Source

build: remove dcheck.patch (#40744)

chore: remove dcheck.patch
Jeremy Rose 1 year ago
parent
commit
66b2f697ea
2 changed files with 0 additions and 37 deletions
  1. 0 1
      patches/chromium/.patches
  2. 0 36
      patches/chromium/dcheck.patch

+ 0 - 1
patches/chromium/.patches

@@ -1,5 +1,4 @@
 build_gn.patch
-dcheck.patch
 accelerator.patch
 blink_file_path.patch
 blink_local_frame.patch

+ 0 - 36
patches/chromium/dcheck.patch

@@ -1,36 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: deepak1556 <[email protected]>
-Date: Thu, 20 Sep 2018 17:44:38 -0700
-Subject: dcheck.patch
-
-This disables some debug checks which currently fail when running the Electron
-test suite. In general there should be sustained effort to have all debug checks
-enabled. If you want to help, choose one of the diffs below and remove it. Then
-build Electron (debug configuration) and make sure all tests pass on the CI
-systems. Unfortunately the tests don't always cover the check failures, so it's
-good to also run some non-trivial Electron app to verify.
-
-Apart from getting rid of a whole diff, you may also be able to replace one diff
-with another which enables at least some of the previously disabled checks. For
-example, the checks might be disabled for a whole build target, but actually
-only one or two specific checks fail. Then it's better to simply comment out the
-failing checks and allow the rest of the target to have them enabled.
-
-diff --git a/ui/base/clipboard/clipboard_win.cc b/ui/base/clipboard/clipboard_win.cc
-index 2ca479b9fb0b41b66220c524e242d4927c138f1f..61a85717ceb02cd0e19297a143ba9b0de8496eeb 100644
---- a/ui/base/clipboard/clipboard_win.cc
-+++ b/ui/base/clipboard/clipboard_win.cc
-@@ -914,10 +914,10 @@ SkBitmap ClipboardWin::ReadBitmapInternal(ClipboardBuffer buffer) const {
- 
- void ClipboardWin::WriteToClipboard(ClipboardFormatType format, HANDLE handle) {
-   UINT cf_format = format.ToFormatEtc().cfFormat;
--  DCHECK_NE(clipboard_owner_->hwnd(), nullptr);
-+  // DCHECK_NE(clipboard_owner_->hwnd(), nullptr);
-   if (handle && !::SetClipboardData(cf_format, handle)) {
--    DCHECK_NE(GetLastError(),
--              static_cast<unsigned long>(ERROR_CLIPBOARD_NOT_OPEN));
-+    // DCHECK_NE(GetLastError(),
-+              // static_cast<unsigned long>(ERROR_CLIPBOARD_NOT_OPEN));
-     ::GlobalFree(handle);
-   }
- }