Browse Source

fix: NSWindow crash happening on macos 10.9 (#15670)

trop[bot] 6 years ago
parent
commit
64874660e1
1 changed files with 5 additions and 0 deletions
  1. 5 0
      atom/browser/native_window_mac.mm

+ 5 - 0
atom/browser/native_window_mac.mm

@@ -517,6 +517,11 @@ void NativeWindowMac::Close() {
 }
 
 void NativeWindowMac::CloseImmediately() {
+  // Retain the child window before closing it. If the last reference to the
+  // NSWindow goes away inside -[NSWindow close], then bad stuff can happen.
+  // See e.g. http://crbug.com/616701.
+  base::scoped_nsobject<NSWindow> child_window(window_,
+                                               base::scoped_policy::RETAIN);
   [window_ close];
 }