Browse Source

fix: exclude crashpad_handler binary on linux (#23538)

Jeremy Apthorp 5 years ago
parent
commit
6282487245

+ 7 - 0
build/zip.py

@@ -25,6 +25,13 @@ PATHS_TO_SKIP = [
   # //chrome/browser/resources/ssl/ssl_error_assistant, but we don't need to
   # ship it.
   'pyproto',
+
+  # On Windows, this binary doesn't exist (the crashpad handler is built-in).
+  # On MacOS, the binary is called 'chrome_crashpad_handler' and is inside the
+  # app bundle.
+  # On Linux, we don't use crashpad, but this binary is still built for some
+  # reason. Exclude it from the zip.
+  './crashpad_handler',
 ]
 
 def skip_path(dep, dist_zip, target_cpu):

+ 0 - 1
script/lib/config.py

@@ -29,7 +29,6 @@ PLATFORM = {
 LINUX_BINARIES = [
   'electron',
   'chrome-sandbox',
-  'crashpad_handler',
   'libffmpeg.so',
   'libGLESv2.so',
   'libEGL.so',

+ 0 - 1
script/zip_manifests/dist_zip.linux.arm.manifest

@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version

+ 0 - 1
script/zip_manifests/dist_zip.linux.arm64.manifest

@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version

+ 0 - 1
script/zip_manifests/dist_zip.linux.x64.manifest

@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version

+ 0 - 1
script/zip_manifests/dist_zip.linux.x86.manifest

@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version