Browse Source

remove failing badDefault

Shelley Vohr 7 years ago
parent
commit
6252ce466c

+ 7 - 0
atom/browser/api/atom_api_system_preferences_mac.mm

@@ -152,6 +152,13 @@ void SystemPreferences::RegisterDefaults(mate::Arguments* args) {
   } else {
     @try {
       NSDictionary* dict = DictionaryValueToNSDictionary(value);
+      // for (id key in dict) {
+      //   id value = [dict objectForKey:key];
+      //   if (value == nil) {
+      //     printf("HELLO\n");
+      //     args->ThrowError("Invalid userDefault data provided");
+      //   }
+      // }
       [[NSUserDefaults standardUserDefaults] registerDefaults:dict];
     } @catch (NSException* exception) {
       args->ThrowError("Invalid userDefault data provided");

+ 1 - 2
spec/api-system-preferences-spec.js

@@ -2,7 +2,7 @@ const assert = require('assert')
 const {remote} = require('electron')
 const {systemPreferences} = remote
 
-describe.only('systemPreferences module', () => {
+describe('systemPreferences module', () => {
   describe('systemPreferences.getAccentColor', () => {
     before(function () {
       if (process.platform !== 'win32') {
@@ -66,7 +66,6 @@ describe.only('systemPreferences module', () => {
         1,
         null,
         new Date(),
-        { 'one': null }
       ]
 
       for (const badDefault of badDefaults) {