Browse Source

Simplify getting callback

Cheng Zhao 8 years ago
parent
commit
622bad1cff
1 changed files with 1 additions and 4 deletions
  1. 1 4
      atom/common/api/atom_api_shell.cc

+ 1 - 4
atom/common/api/atom_api_shell.cc

@@ -58,14 +58,11 @@ bool OpenExternal(
   }
 
   if (args->Length() >= 3) {
-    v8::Local<v8::Value> peek = args->PeekNext();
     platform_util::OpenExternalCallback callback;
-    if (mate::Converter<platform_util::OpenExternalCallback>::FromV8(
-      args->isolate(), peek, &callback)) {
+    if (args->GetNext(&callback)) {
       platform_util::OpenExternal(url, activate, callback);
       return true;
     }
-    return false;
   }
 
   return platform_util::OpenExternal(url, activate);