Browse Source

Merge pull request #6705 from electron/remove-view-painted

Remove the view-painted event
Cheng Zhao 8 years ago
parent
commit
617820dfc2

+ 0 - 5
atom/browser/api/atom_api_web_contents.cc

@@ -757,7 +757,6 @@ bool WebContents::OnMessageReceived(const IPC::Message& message) {
     IPC_MESSAGE_HANDLER(AtomViewHostMsg_Message, OnRendererMessage)
     IPC_MESSAGE_HANDLER_DELAY_REPLY(AtomViewHostMsg_Message_Sync,
                                     OnRendererMessageSync)
-    IPC_MESSAGE_HANDLER(AtomViewHostMsg_DidCommitCompositorFrame, OnViewPainted)
     IPC_MESSAGE_HANDLER_CODE(ViewHostMsg_SetCursor, OnCursorChange,
       handled = false)
     IPC_MESSAGE_UNHANDLED(handled = false)
@@ -1331,10 +1330,6 @@ void WebContents::OnCursorChange(const content::WebCursor& cursor) {
   }
 }
 
-void WebContents::OnViewPainted() {
-  Emit("view-painted");
-}
-
 void WebContents::SetSize(const SetSizeParams& params) {
   if (guest_delegate_)
     guest_delegate_->SetSize(params);

+ 0 - 3
atom/browser/api/atom_api_web_contents.h

@@ -307,9 +307,6 @@ class WebContents : public mate::TrackableObject<WebContents>,
                              const base::ListValue& args,
                              IPC::Message* message);
 
-  // Called when the hosted view gets graphical updates.
-  void OnViewPainted();
-
   v8::Global<v8::Value> session_;
   v8::Global<v8::Value> devtools_web_contents_;
   v8::Global<v8::Value> debugger_;

+ 0 - 2
atom/common/api/api_messages.h

@@ -39,7 +39,5 @@ IPC_MESSAGE_ROUTED3(AtomViewMsg_Message,
 IPC_MESSAGE_ROUTED1(AtomViewHostMsg_UpdateDraggableRegions,
                     std::vector<atom::DraggableRegion> /* regions */)
 
-IPC_MESSAGE_ROUTED0(AtomViewHostMsg_DidCommitCompositorFrame)
-
 // Update renderer process preferences.
 IPC_MESSAGE_CONTROL1(AtomMsg_UpdatePreferences, base::ListValue)

+ 0 - 4
atom/renderer/atom_render_view_observer.cc

@@ -141,10 +141,6 @@ void AtomRenderViewObserver::DraggableRegionsChanged(blink::WebFrame* frame) {
   Send(new AtomViewHostMsg_UpdateDraggableRegions(routing_id(), regions));
 }
 
-void AtomRenderViewObserver::DidCommitCompositorFrame() {
-  Send(new AtomViewHostMsg_DidCommitCompositorFrame(routing_id()));
-}
-
 bool AtomRenderViewObserver::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AtomRenderViewObserver, message)

+ 0 - 1
atom/renderer/atom_render_view_observer.h

@@ -28,7 +28,6 @@ class AtomRenderViewObserver : public content::RenderViewObserver {
   // content::RenderViewObserver implementation.
   void DidCreateDocumentElement(blink::WebLocalFrame* frame) override;
   void DraggableRegionsChanged(blink::WebFrame* frame) override;
-  void DidCommitCompositorFrame() override;
   bool OnMessageReceived(const IPC::Message& message) override;
 
   void OnBrowserMessage(bool send_to_all,

+ 0 - 4
docs/api/web-contents.md

@@ -457,10 +457,6 @@ app.on('ready', () => {
 })
 ```
 
-#### Event: 'view-painted'
-
-Emitted when a page's view is repainted.
-
 #### Event: 'paint'
 
 Returns: