Browse Source

test: re-enable some Node.js specs (#31077)

Shelley Vohr 3 years ago
parent
commit
5e1fbc9025
2 changed files with 20 additions and 44 deletions
  1. 20 0
      patches/node/fix_crypto_tests_to_run_with_bssl.patch
  2. 0 44
      script/node-disabled-tests.json

+ 20 - 0
patches/node/fix_crypto_tests_to_run_with_bssl.patch

@@ -10,6 +10,26 @@ This should be upstreamed in some form, though it may need to be tweaked
 before it's acceptable to upstream, as this patch comments out a couple
 of tests that upstream probably cares about.
 
+diff --git a/test/parallel/test-crypto-async-sign-verify.js b/test/parallel/test-crypto-async-sign-verify.js
+index 4e3c32fdcd23fbe3e74bd5e624b739d224689f33..19d65aae7fa8ec9f9b907733ead17a208ed47909 100644
+--- a/test/parallel/test-crypto-async-sign-verify.js
++++ b/test/parallel/test-crypto-async-sign-verify.js
+@@ -88,6 +88,7 @@ test('rsa_public.pem', 'rsa_private.pem', 'sha256', false,
+ // ED25519
+ test('ed25519_public.pem', 'ed25519_private.pem', undefined, true);
+ // ED448
++/*
+ test('ed448_public.pem', 'ed448_private.pem', undefined, true);
+ 
+ // ECDSA w/ der signature encoding
+@@ -109,6 +110,7 @@ test('dsa_public.pem', 'dsa_private.pem', 'sha256',
+ // DSA w/ ieee-p1363 signature encoding
+ test('dsa_public.pem', 'dsa_private.pem', 'sha256', false,
+      { dsaEncoding: 'ieee-p1363' });
++*/
+ 
+ // Test Parallel Execution w/ KeyObject is threadsafe in openssl3
+ {
 diff --git a/test/parallel/test-crypto-authenticated.js b/test/parallel/test-crypto-authenticated.js
 index 21c5af6cfe3e5eef64fc2d4dcc63c55b1d79ad51..b21eb4b97ad778304b3a4e8d549e109614350dfb 100644
 --- a/test/parallel/test-crypto-authenticated.js

+ 0 - 44
script/node-disabled-tests.json

@@ -2,11 +2,6 @@
   "abort/test-abort-backtrace",
   "async-hooks/test-crypto-pbkdf2",
   "async-hooks/test-crypto-randomBytes",
-  "message/source_map_throw_catch",
-  "message/source_map_throw_first_tick",
-  "message/source_map_throw_set_immediate",
-  "message/v8_warning",
-  "parallel/test-assert",
   "parallel/test-bootstrap-modules",
   "parallel/test-buffer-backing-arraybuffer",
   "parallel/test-buffer-constructor-node-modules-paths",
@@ -18,7 +13,6 @@
   "parallel/test-cluster-shared-handle-bind-privileged-port",
   "parallel/test-code-cache",
   "parallel/test-crypto-aes-wrap",
-  "parallel/test-crypto-async-sign-verify",
   "parallel/test-crypto-authenticated-stream",
   "parallel/test-crypto-certificate",
   "parallel/test-crypto-des3-wrap",
@@ -28,35 +22,18 @@
   "parallel/test-crypto-fips",
   "parallel/test-crypto-hkdf.js",
   "parallel/test-crypto-secure-heap",
-  "parallel/test-debug-args",
-  "parallel/test-debug-usage",
-  "parallel/test-debugger-pid",
-  "parallel/test-domain-abort-on-uncaught",
-  "parallel/test-domain-with-abort-on-uncaught-exception",
-  "parallel/test-finalization-group-error",
-  "parallel/test-freeze-intrinsics",
   "parallel/test-fs-utimes-y2K38",
-  "parallel/test-gc-tls-external-memory",
   "parallel/test-http2-clean-output",
-  "parallel/test-http2-reset-flood",
   "parallel/test-https-agent-session-reuse",
   "parallel/test-https-options-boolean-check",
-  "parallel/test-inspector-inspect-brk-node",
   "parallel/test-inspector-multisession-ws",
   "parallel/test-inspector-port-zero-cluster",
   "parallel/test-inspector-tracing-domain",
-  "parallel/test-inspector-vm-global-accessors-getter-sideeffect",
-  "parallel/test-inspector-vm-global-accessors-sideeffects",
   "parallel/test-module-loading-globalpaths",
-  "parallel/test-module-run-main-monkey-patch",
   "parallel/test-module-version",
   "parallel/test-openssl-ca-options",
-  "parallel/test-policy-integrity",
   "parallel/test-process-env-allowed-flags-are-documented",
-  "parallel/test-process-external-stdio-close",
-  "parallel/test-process-external-stdio-close-spawn",
   "parallel/test-process-versions",
-  "parallel/test-readline-interface",
   "parallel/test-repl",
   "parallel/test-repl-harmony",
   "parallel/test-repl-pretty-custom-stack",
@@ -134,14 +111,8 @@
   "parallel/test-trace-events-v8",
   "parallel/test-trace-events-vm",
   "parallel/test-trace-events-worker-metadata",
-  "parallel/test-util-inspect",
-  "parallel/test-v8-coverage",
   "parallel/test-v8-flags",
   "parallel/test-v8-untrusted-code-mitigations",
-  "parallel/test-vm-module-basic",
-  "parallel/test-vm-parse-abort-on-uncaught-exception",
-  "parallel/test-vm-sigint-existing-handler",
-  "parallel/test-vm-timeout",
   "parallel/test-webcrypto-derivebits-hkdf",
   "parallel/test-webcrypto-derivebits-node-dh",
   "parallel/test-webcrypto-ed25519-ed448",
@@ -153,17 +124,8 @@
   "parallel/test-webcrypto-sign-verify-node-dsa",
   "parallel/test-webcrypto-x25519-x448",
   "parallel/test-whatwg-encoding-custom-textdecoder",
-  "parallel/test-worker-message-channel",
-  "parallel/test-worker-message-port",
-  "parallel/test-worker-message-port-transfer-duplicate",
-  "parallel/test-worker-message-port-transfer-target",
-  "parallel/test-worker-resource-limits",
-  "parallel/test-worker-sharedarraybuffer-from-worker-thread",
   "parallel/test-worker-stdio",
-  "parallel/test-worker-workerdata-messageport",
   "parallel/test-zlib-unused-weak",
-  "pseudo-tty/test-set-raw-mode-reset-process-exit",
-  "pseudo-tty/test-set-raw-mode-reset-signal",
   "report/test-report-fatal-error",
   "report/test-report-getreport",
   "report/test-report-signal",
@@ -172,13 +134,7 @@
   "report/test-report-uv-handles",
   "report/test-report-worker",
   "report/test-report-writereport",
-  "sequential/test-inspector-contexts",
-  "sequential/test-inspector-port-zero",
-  "sequential/test-inspector-resource-name-to-url",
-  "sequential/test-inspector-stress-http",
-  "sequential/test-perf-hooks",
   "sequential/test-tls-connect",
-  "sequential/test-vm-timeout-rethrow",
   "sequential/test-worker-prof",
   "wpt/test-encoding",
   "wpt/test-webcrypto"