Browse Source

test: disable flaky asar worker test on ASan build (#38193)

Calvin 1 year ago
parent
commit
58d49927a3
1 changed files with 3 additions and 2 deletions
  1. 3 2
      spec/asar-spec.ts

+ 3 - 2
spec/asar-spec.ts

@@ -4,7 +4,7 @@ import * as url from 'url';
 import { Worker } from 'worker_threads';
 import { BrowserWindow, ipcMain } from 'electron/main';
 import { closeAllWindows } from './lib/window-helpers';
-import { getRemoteContext, ifdescribe, itremote, useRemoteContext } from './lib/spec-helpers';
+import { getRemoteContext, ifdescribe, ifit, itremote, useRemoteContext } from './lib/spec-helpers';
 import * as importedFs from 'fs';
 import { once } from 'events';
 
@@ -115,7 +115,8 @@ describe('asar package', () => {
   });
 
   describe('worker threads', function () {
-    it('should start worker thread from asar file', function (callback) {
+    // DISABLED-FIXME(#38192): only disabled for ASan.
+    ifit(!process.env.IS_ASAN)('should start worker thread from asar file', function (callback) {
       const p = path.join(asarDir, 'worker_threads.asar', 'worker.js');
       const w = new Worker(p);