Browse Source

fix: make isDarkMode correctly detect dark mode in the auto setting on catalina (#18949)

Samuel Attard 5 years ago
parent
commit
5686a0713e
1 changed files with 4 additions and 0 deletions
  1. 4 0
      shell/browser/api/atom_api_system_preferences_mac.mm

+ 4 - 0
shell/browser/api/atom_api_system_preferences_mac.mm

@@ -628,6 +628,10 @@ void SystemPreferences::RemoveUserDefault(const std::string& name) {
 }
 
 bool SystemPreferences::IsDarkMode() {
+  if (@available(macOS 10.14, *)) {
+    return [[NSApplication sharedApplication].effectiveAppearance.name
+        isEqualToString:NSAppearanceNameDarkAqua];
+  }
   NSString* mode = [[NSUserDefaults standardUserDefaults]
       stringForKey:@"AppleInterfaceStyle"];
   return [mode isEqualToString:@"Dark"];