Browse Source

Leak the Node environment when context is released

Cheng Zhao 7 years ago
parent
commit
5253c0a816
1 changed files with 6 additions and 1 deletions
  1. 6 1
      atom/renderer/atom_renderer_client.cc

+ 6 - 1
atom/renderer/atom_renderer_client.cc

@@ -135,7 +135,12 @@ void AtomRendererClient::WillReleaseScriptContext(
     node_bindings_->set_uv_env(nullptr);
 
   // Destroy the node environment.
-  node::FreeEnvironment(env);
+  // This is disabled because pending async tasks may still use the environment
+  // and would cause crashes later. Node does not seem to clear all async tasks
+  // when the environment is destroyed.
+  // node::FreeEnvironment(env);
+
+  // AtomBindings is tracking node environments.
   atom_bindings_->EnvironmentDestroyed(env);
 }